Skip to content

6314: Fix crash on startup #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RitikaPahwa4444
Copy link
Collaborator

Description (required)

Fixes #6314

What changes did you make and why?

Bumped up the database version to fix the crash on app startup. Also bumped up the version code for release.

Tests performed (required)

Tested prodRelease on moto g34 5G with API level 34.

Screenshots (for UI changes only)

NA

Copy link

✅ Generated APK variants!

@chrisdebian
Copy link

I have downloaded and extracted the prodDebug APK, but Play will not let me install it, saying something is wrong.

Screenshot_20250524-134201

@nicolas-raoul
Copy link
Member

Maybe because of different signature.

@rohit9625
Copy link
Contributor

I have downloaded and extracted the prodDebug APK, but Play will not let me install it, saying something is wrong.

Make sure you don't have any other version of Commons installed on your phone already.

@RitikaPahwa4444
Copy link
Collaborator Author

@rohit9625 that won't help with the testing here. Reinstallation will anyway fix the issue 😅

@nicolas-raoul
Copy link
Member

Sorry the conflict is probably caused by me merging the build files changes... Ritika, feel free to commit such changes directly into main. :-)

@RitikaPahwa4444
Copy link
Collaborator Author

@nicolas-raoul I had been committing directly only but this time I raised a PR so that the APKs get generated. My bad, we don't generate release builds and this couldn't help with the testing as we didn't have a signed APK here (I had personally tested the release build, though). Will improve this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: v5.4.0 beta Crash on StartUp (java.lang.IllegalStateException)
4 participants